-
Notifications
You must be signed in to change notification settings - Fork 1
closest-observation Sentinel-2 ingest builder (issue #509) #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
605cb56
phase 1 of issue #509
espg f70d60a
fold review: expand cover words to bucket midpoints (issue #509)
espg 1cec8ed
fold review: make the cross-store union canonical at the bucket grid …
espg a6642f6
fold review: honor each block's effective temporal order (issue #509)
espg 970d7a0
fold review: pin the golden fixture epochs as literals (issue #509)
espg 16777c4
phase 2 of issue #509
espg e6efd13
fold review: snap equal-time runs to their first record (issue #509)
espg fc2a53e
fold review: refuse NaT in either input (issue #509)
espg ad6a311
fold review: exact unsigned flank distances across the full span (iss…
espg be41a26
phase 3 of issue #509
espg 96ca33b
fold review: stop advertising a mask the derived map does not carry (…
espg ccb6b9b
fold review: ledger the epochs of shards the catalog never reaches (i…
espg 23e391f
fold review: emit the paired instant as the entry's datetime (issue #…
espg 2d72afa
fold review: apply the aoi to both sides of the join (issue #509)
espg ada8a48
fold review: warn that a reprojected map loses the pairing provenance…
espg f26f20c
phase 4 of issue #509
espg e9ac3c8
fold review: pin the gap test's shoulder selections by name (issue #509)
espg 1228b3e
fold review: make store A contribute uniquely to the union (issue #509)
espg bb870dc
fold review: pass the gate in the dry-run example so violations is re…
espg 8a925d1
Merge remote-tracking branch 'origin/main' into claude/509-s2-closest…
espg e9a23ce
fold review: raise the function-zip budget to 32 MB (issue #509)
espg ecca696
fold review: tolerance-aware handling of coarsened cover blocks (issu…
espg 073242e
fold review: gate cover resolution before the spatial lookup (issue #…
espg ae30bab
fold review: warn loudly when a coarsened cover drops epochs (issue #…
espg 7df30da
fold review: refuse a negative cover block order at the read boundary…
espg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 from Claude (review)
The dry-run example cannot report what the prose two paragraphs down promises it reports: "a shard past
max_granules_per_shardraises naming the worst shards (estimate=Truereports the violations instead, so the gate can be sized first)". Thisestimate=Truecall omitsmax_granules_per_shard, andviolationsis computed from that argument —[]whenever it isNone.Probe (
uv run python, synthetic two-store fixture, one shard with 5 selected granules):So a reader who copies this block verbatim to "size the run first" gets a silent
violations == [], then hits the raise on the very next call — the failure the dry run exists to prevent. (estimatereturns before the violations raise inclosest_obs_shardmap, so passing the gate here is safe and non-raising.)Fix: pass the same gate in the dry run as in the build, and surface it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 from Claude
Fixed in bb870dc. The dry-run call now passes
max_granules_per_shard=200— the same gate the build call below it uses — and the trailing line readsest["histogram"], est["max_cost_usd"], est["violations"], with a short comment saying why the gate has to be repeated here and thatestimatereturns before the raise.Re-probed the behaviour the fix depends on, on a synthetic two-store fixture:
so the gated dry run is non-raising and reports what the prose promises.
mkdocs build --strictis green.