Skip to content

Fix GPU aware MPI#202

Merged
haykh merged 3 commits into
1.4.0rcfrom
dev/gpu_mpi_fix2
May 12, 2026
Merged

Fix GPU aware MPI#202
haykh merged 3 commits into
1.4.0rcfrom
dev/gpu_mpi_fix2

Conversation

@LudwigBoess
Copy link
Copy Markdown
Collaborator

This PR fixes an issue with the GPU aware MPI on Intel PVC GPUs

@LudwigBoess LudwigBoess changed the title Dev/gpu mpi fix2 Fix GPU aware MPI May 8, 2026
@LudwigBoess LudwigBoess mentioned this pull request May 8, 2026
@LudwigBoess
Copy link
Copy Markdown
Collaborator Author

This version fixes the MPI issue while retaining the option to switch off GPU aware MPI.

The comm issue seems to be fixed by the explicit Kokkos::fence();
turb_n_00000002

This decreases the communication time by ~10% in this test
communication_time_n

@LudwigBoess LudwigBoess requested a review from haykh May 8, 2026 02:47
@LudwigBoess
Copy link
Copy Markdown
Collaborator Author

@haykh please sanity check the change in the last commit. I think that em was duplicate for SR. It's in the else of the GR branch, but it's already outside of the branch. So in GR it's called once, in SR twice.

@LudwigBoess LudwigBoess marked this pull request as ready for review May 9, 2026 14:41
@LudwigBoess
Copy link
Copy Markdown
Collaborator Author

This is the updated comm timing after the last commit
communication_time_n2

@haykh haykh merged commit 63b0647 into 1.4.0rc May 12, 2026
6 checks passed
@haykh haykh deleted the dev/gpu_mpi_fix2 branch May 12, 2026 05:50
@haykh haykh mentioned this pull request May 12, 2026
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants