French translations and New countries#152
Open
SebastienLinker wants to merge 4 commits into
Open
Conversation
Collaborator
|
Thanks for the contribution. Can you write up some test cases as well since that helps us understand how the tax code works in Belgium. You don't have to actually write the code, I can let Claude Code do that, but just some basic scenarios. If not, when I have time, I can let claude code do the research and build out the cases. Let me know. |
Author
|
I'll work on that |
SebastienLinker
marked this pull request as draft
June 9, 2026 23:25
SebastienLinker
marked this pull request as ready for review
June 10, 2026 22:43
Author
|
@macanudo527 I added the golden inputs and a few comments similar to what we have for Japan and Spain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a French translation (thanks to ChatGPT, and I double-checked)
I am planning to work on the average cost calculation method used in France and Switzerland. FIFO method seems to be the correct calculation method in Belgium and Luxembourg, so it should be valid out of the box for these countries.