Skip to content

xercesc 3.2.2 namespace update#2

Open
armtir wants to merge 2 commits into
epri-dev:masterfrom
armtir:master
Open

xercesc 3.2.2 namespace update#2
armtir wants to merge 2 commits into
epri-dev:masterfrom
armtir:master

Conversation

@armtir

@armtir armtir commented Nov 9, 2020

Copy link
Copy Markdown

No description provided.

@beroset beroset left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use XERCES_CPP_NAMESPACE instead of simply xercesc? This documentation seems to suggest the latter instead.

@armtir

armtir commented Nov 9, 2020

Copy link
Copy Markdown
Author

Hello, you're right, it's better to use xercesc . In XercesDefs.hpp:110 it's defined as: namespace xercesc = XERCES_CPP_NAMESPACE;

@armtir

armtir commented Nov 9, 2020

Copy link
Copy Markdown
Author

There is one more issue with the unittest CurlReceiveBuffer.TestBuffer1.
I had to add carriage returns (\r ) to this file: test_buffer1.txt.

@beroset

beroset commented Nov 12, 2020

Copy link
Copy Markdown
Member

There is one more issue with the unittest CurlReceiveBuffer.TestBuffer1.
I had to add carriage returns (\r ) to this file: test_buffer1.txt.

Yes, I put in a pull request to address that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants