Fix planner map preview rendering and escape generated content - #440
Open
ercmine wants to merge 1 commit into
Open
Fix planner map preview rendering and escape generated content#440ercmine wants to merge 1 commit into
ercmine wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
innerHTML, which risked unsafe rendering and poor UX.Description
escapeHtmlhelper to sanitize itinerary title, summary, and stop fields before injecting intoinnerHTML.buildMapSrcwhich constructs a Google Maps embed query from up to 5 stop addresses/place titles plus city context and returns an embedsrcURL.buildMapSrcreturns a non-empty URL, instead of relying on pre-existing hidden DOM nodes.web/src/pages/planner.astroand ensure the planner result block includes the sanitized itinerary and optional map iframe.Testing
pnpm --dir web build; the planner page changes compiled successfully but the full build fails due to a pre-existing unrelated SSR error (window is not definedinsrc/pages/marketplace.astro).planner.astrorenders sanitized HTML with the constructedsrcincluded in the iframe markup when itinerary data is present.Codex Task