Add Deck browsing feature with controller, UI, routing, and format helpers - #45
Add Deck browsing feature with controller, UI, routing, and format helpers#45ercmine wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86efa449b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _telemetryRepository().then((repo) async { | ||
| repo.enqueue(state.sessionId, event); | ||
| await repo.flush(state.sessionId); | ||
| }); |
There was a problem hiding this comment.
Serialize telemetry flushes per session
Each call to _enqueueTelemetry starts repo.flush(...) in a detached then block, so rapid interactions can run multiple flushes concurrently for the same session. TelemetryRepository.flush mutates a shared queue (removeRange in a loop), so overlapping flushes can send duplicate batches and then fail mid-drain when one flush removes items the other still expects, which makes analytics inaccurate under normal swipe/open bursts.
Useful? React with 👍 / 👎.
Motivation
Description
deck_state.dart), controller (deck_controller.dart) with telemetry, location and repository integration, and a new route at/sessions/:id/deckwired intorouter.dartandsession_page.dart.deck_page.dartand a set of widgets for cards and details (deck_card.dart,deck_card_skeleton.dart,deck_actions_bar.dart,card_details_sheet.dart, and several small badges/pills), and hooked link launching into existinglinkLauncherProviderusage.deckControllerProviderinproviders/app_providers.dart, added format helpers incore/format/formatters.dart, and updatedpubspec.yamlto includeflutter_card_swiper,cached_network_image, andcollectiondependencies.Testing
flutter analyzeto ensure static analysis and imports are correct and it completed successfully.flutter testand unit/widget tests completed successfully (no failing tests).Codex Task