Add Deck browsing feature with controller, UI, routing, and format helpers - #46
Add Deck browsing feature with controller, UI, routing, and format helpers#46ercmine wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2061447167
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _telemetryRepository().then((repo) async { | ||
| repo.enqueue(state.sessionId, event); | ||
| await repo.flush(state.sessionId); | ||
| }); |
There was a problem hiding this comment.
In DeckController, _swipe emits two telemetry events back-to-back (card_viewed then swipe), and _enqueueTelemetry starts repo.flush in a fire-and-forget callback each time. That allows concurrent TelemetryRepository.flush executions on the same queue; because each flush computes takeCount, awaits network I/O, then mutates with removeRange, overlapping completions can remove overlapping ranges and raise RangeError or lose/duplicate events during normal fast swiping.
Useful? React with 👍 / 👎.
| nextCursor: response.nextCursor, | ||
| hasMore: response.nextCursor != null, | ||
| lastBatchMix: response.mix, | ||
| usedFallback: response.plans.isEmpty || fallbackCount >= (response.plans.length ~/ 2), |
There was a problem hiding this comment.
The fallback flag uses fallbackCount >= (response.plans.length ~/ 2), which floors odd lengths and makes the threshold too low (for example, 1-card batches always mark fallback active because the threshold becomes 0, and 3-card batches mark it active at only 33%). This causes false fallback labeling and misleading deck quality signals whenever batch size is odd.
Useful? React with 👍 / 👎.
1 participant
Motivation
Description
deck_state.dart), controller (deck_controller.dart) with telemetry, location and repository integration, and a new route at/sessions/:id/deckwired intorouter.dartandsession_page.dart.deck_page.dartand a set of widgets for cards and details (deck_card.dart,deck_card_skeleton.dart,deck_actions_bar.dart,card_details_sheet.dart, and several small badges/pills), and hooked link launching into existinglinkLauncherProviderusage.deckControllerProviderinproviders/app_providers.dart, added format helpers incore/format/formatters.dart, and updatedpubspec.yamlto includeflutter_card_swiper,cached_network_image, andcollectiondependencies.Testing
flutter analyzeto ensure static analysis and imports are correct and it completed successfully.flutter testand unit/widget tests completed successfully (no failing tests).Codex Task