Add Deck browsing feature with controller, UI, routing, and format helpers - #51
Add Deck browsing feature with controller, UI, routing, and format helpers#51ercmine wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb401f1cd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _telemetryRepository().then((repo) async { | ||
| repo.enqueue(state.sessionId, event); | ||
| await repo.flush(state.sessionId); |
There was a problem hiding this comment.
Serialize telemetry flushes per session
Each telemetry event starts a fire-and-forget repo.flush(...) via .then, so rapid interactions (multiple swipes/taps in quick succession) can run TelemetryRepository.flush concurrently on the same in-memory queue. Because flush removes ranges after awaiting network I/O, overlapping flushes can remove stale indices, causing dropped/duplicated events or RangeError at runtime; this corrupts deck telemetry under normal user behavior.
Useful? React with 👍 / 👎.
| isLoadingInitial: true, | ||
| plans: const [], | ||
| nextCursor: null, | ||
| errorMessage: null, | ||
| ); |
There was a problem hiding this comment.
Clear undo state when refreshing deck data
Refreshing only resets loading flags and plans, but leaves undoStack (and shown-card history) intact. After a retry/refresh, the Undo button can still restore cards from the previous batch into the newly fetched deck, mixing stale suggestions with current results and skewing subsequent swipe flow/telemetry.
Useful? React with 👍 / 👎.
Motivation
Description
deck_state.dart), controller (deck_controller.dart) with telemetry, location and repository integration, and a new route at/sessions/:id/deckwired intorouter.dartandsession_page.dart.deck_page.dartand a set of widgets for cards and details (deck_card.dart,deck_card_skeleton.dart,deck_actions_bar.dart,card_details_sheet.dart, and several small badges/pills), and hooked link launching into existinglinkLauncherProviderusage.deckControllerProviderinproviders/app_providers.dart, added format helpers incore/format/formatters.dart, and updatedpubspec.yamlto includeflutter_card_swiper,cached_network_image, andcollectiondependencies.Testing
flutter analyzeto ensure static analysis and imports are correct and it completed successfully.flutter testand unit/widget tests completed successfully (no failing tests).Codex Task