Add Deck browsing feature with controller, UI, routing, and format helpers - #53
Add Deck browsing feature with controller, UI, routing, and format helpers#53ercmine wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fa2653efc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| state = state.copyWith( | ||
| isLoadingInitial: true, | ||
| plans: const [], | ||
| nextCursor: null, | ||
| errorMessage: null, |
There was a problem hiding this comment.
refresh() resets the card list but leaves undoStack and shownPlanIds untouched, so after a retry/pull-to-refresh users can still undo into cards from the previous deck and telemetry positions continue from the old run; this mixes stale state into what should be a fresh batch load.
Useful? React with 👍 / 👎.
| _telemetryRepository().then((repo) async { | ||
| repo.enqueue(state.sessionId, event); | ||
| await repo.flush(state.sessionId); | ||
| }); |
There was a problem hiding this comment.
Each telemetry event triggers an unawaited _enqueueTelemetry call that immediately flushes, so rapid interactions (for example card_viewed + swipe emitted back-to-back) can run overlapping flushes on the same session queue; TelemetryRepository.flush mutates a shared list, so concurrent flushes can send duplicate batches or leave events unsafely handled after removeRange races.
Useful? React with 👍 / 👎.
1 participant
Motivation
Description
deck_state.dart), controller (deck_controller.dart) with telemetry, location and repository integration, and a new route at/sessions/:id/deckwired intorouter.dartandsession_page.dart.deck_page.dartand a set of widgets for cards and details (deck_card.dart,deck_card_skeleton.dart,deck_actions_bar.dart,card_details_sheet.dart, and several small badges/pills), and hooked link launching into existinglinkLauncherProviderusage.deckControllerProviderinproviders/app_providers.dart, added format helpers incore/format/formatters.dart, and updatedpubspec.yamlto includeflutter_card_swiper,cached_network_image, andcollectiondependencies.Testing
flutter analyzeto ensure static analysis and imports are correct and it completed successfully.flutter testand unit/widget tests completed successfully (no failing tests).Codex Task