Add engine-owned scene system with hierarchy, cameras, lights and renderables (Statement 11) - #11
Merged
ercmine merged 1 commit intoApr 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
engine/scene/exposingScene,SceneNodeId(index+generation),CameraComponent,LightComponent,RenderableComponent, visibility/layer masks, reparent policies, and debug name APIs (engine/scene/scene.hppandengine/scene/scene.cpp).lookup, and generation bump/free-list reuse on destroy.ReparentPolicy(KeepLocalTransform/KeepWorldTransform), subtree dirty propagation, andupdate_world_transforms()for top-down world transform computation.build_camera_view(...),collect_visible_renderables(...), andcollect_visible_lights(...), and integrated the scene into the shell sorender_shellbuilds a small demo scene and submits visible renderables to the renderer without leaking backend types.engine/scene/README.md,docs/scene.md) and updateddocs/architecture.mdanddocs/rendering.mdto mention the scene integration, and wired the scene into CMake with arender_scenelibrary andrender_scene_teststarget.Testing
tests/scene/scene_tests.cppand supporting core files withg++and executing the binary, which succeeded (test assertions passed).tests/core/core_runtime_tests.cpp) via directg++invocation and the test succeeded.cmake --preset linux-debug, which failed in this environment due to missing external dependencies (SDL3/bgfx); this is an environment issue and does not affect the scene module unit tests executed above.Codex Task