Statement 12: Add geometry submission foundation (mesh/index/instance buffers, batching, instancing) - #12
Merged
ercmine merged 1 commit intoApr 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
engine/render/buffer_types.*and wired layout validation into the bgfx backend.engine/render/draw_submission.*and extendedRendererAPI to create/update mesh/index/instance buffers and to submit unique or instanced draws (submit/submit_instanced).engine/render/bgfx/renderer_bgfx.cpp) including index type mapping, index/vertex creation, instanced submission via bgfx instance buffers, and safe destruction paths.engine/shell/main.cpp) to extract visible renderables, buildDrawSubmissionrecords, run batch planning, and emit either unique or instanced submissions; updated scene renderable bindings to use the new material/mesh fields.Testing
tests/render/geometry_submission_tests.cppthat validates vertex layout, CPU mesh data consistency, batching grouping, and instancing threshold behavior and wired it into CMake/CTest asunit.renderer.geometry_submission.cmake --preset linux-debug) to validate project changes, but configuration failed due to unresolved external dependencies (SDL3/bgfx) in the environment so a full build and test run could not be completed.Codex Task