Add lightweight render pass orchestration (render graph) and shell integration - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
dump_graph()inengine/render/render_pass_system.hppandengine/render/render_pass_system.cpp.depends_onplus inferred producer→consumer edges.RenderResourceDesc) supportingRenderTarget,DepthTarget,ShadowMap,PostProcessTexture,UiTarget, and importedBackbuffer, and a resource-usage model (RenderPassResourceUsage) withRead/Write/ReadWriteintents.engine/shell/main.cpp) so the frame is now assembled through named passes:shadow-pass,main-lit-pass,bloom-extract-pass,bloom-blur-pass,bloom-composite-pass,outline-pass,ui-pass,debug-pass, andpresent-pass, including declared resources and explicit dependencies.RendererPassTimingand track active/inactive passes viaRenderPassDiagnostics.tests/render/render_pass_system_tests.cppvalidating pass registration, execution ordering, enable/disable behavior, missing-producer detection, and cycle detection.render_rendererlibrary, added therender_render_pass_system_teststarget and CTest entry, and documented the system and current frame layout indocs/rendering.mdandengine/render/README.md.Files created or updated (high level):
engine/render/render_pass_system.hpp,engine/render/render_pass_system.cpp,tests/render/render_pass_system_tests.cpp,engine/shell/main.cpp,CMakeLists.txt,docs/rendering.md,engine/render/README.md.Testing
render_render_pass_system_testswhich exercises ordering, validation, enable/disable behavior, and cycle detection and is intentionally deterministic and headless; the test source lives attests/render/render_pass_system_tests.cpp.cmake --preset linux-debugandcmake --build --preset linux-debug --target render_render_pass_system_tests render_shell; configuration/build failed in this environment due to unresolved external dependencies (SDL3 and bgfx/bx/bimg), so the new unit test was not executed here.Codex Task