Update terrains.json - #1155
Closed
Xolgrim wants to merge 1 commit into
Closed
Conversation
Feuerwand zu Landregion gemacht, damit Schiffe in der Nähe nicht mehr abtreiben können.
Member
|
Das geht so nicht, "land"hat eine Menge andere Nebenwirkungen. Mit dieser Änderung würdest du es z.B. unmöglich machen, das alte Datenfile zu laden :-) Ohne einen Bugreport sehe ich keinen Grund, hier etwas zu ändern. Mit einem Bugreport könnte man einen Test schreiben. Dann könnte man gleich auch gucken, waum die Probleme dieser Änderung keinen Alarm ausgelöst haben (einen Test, der das Datenfile liest, haben wir wohl nicht im CI Build?). |
ennorehling
self-requested a review
August 24, 2026 06:17
Member
|
NB: Es ging hier um https://bugs.eressea.de/view.php?id=3119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted Feuerwand into a land region to prevent nearby ships from drifting away.