erts: Check for duplicated native record fields in binary_to_term/1 - #11410
Merged
lucioleKi merged 1 commit intoAug 5, 2026
Merged
Conversation
Contributor
CT Test Results 3 files 136 suites 48m 57s ⏱️ Results for commit 9c7adf5. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
lucioleKi
added
team:VM
jhogberg
approved these changes
Aug 5, 2026
| qsort(fields, num_fields, sizeof(struct erl_record_field), | ||
| (int (*)(const void *, const void *)) record_compare); | ||
|
|
||
| for (Sint i = 1; i < num_fields; i++) { |
Contributor
There was a problem hiding this comment.
Nitpick for later: it might be worth sorting ourselves so that we won't have to compare keys once again here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11398