Allow non-square images in the prepsfmom fitters - #273
Merged
Conversation
Internally the images are zero padded to square, and apodization still works correctly. The effective pad factor used to scale the noise is now the ratio of padded to unpadded pixel counts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PK1a41EiKVLGjyq3Bp6RGa
Owner
Author
|
Claude code was used to split this from #271 |
beckermr
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #271 at reviewer request.
The pre-PSF moment fitters (
KSigmaMom,PGaussMom) previously raised on non-square images. They now zero pad to square internally: the target dimension is the largest dimension of the image and psf timespad_factor, and the effective pad factor used to scale the noise is the ratio of padded to unpadded pixel counts. Apodization still works correctly._zero_pad_imagenow pads each axis separately and returns the row and column offsets.Tests cover trimming either axis and check results against the square case.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PK1a41EiKVLGjyq3Bp6RGa