Skip to content

feat: support Node 24#43

Merged
JoshTheWanderer merged 2 commits into
mainfrom
feat/support-node-24
Jun 24, 2026
Merged

feat: support Node 24#43
JoshTheWanderer merged 2 commits into
mainfrom
feat/support-node-24

Conversation

@gavmck

@gavmck gavmck commented Jun 17, 2026

Copy link
Copy Markdown
Member

Why

Node 24 is the current LTS. Downstream consumers moving to it (e.g. the Admiral Design System bumping its .nvmrc/engines to Node 24) hit an npm warn EBADENGINE because this package's engines.node tops out at ^22:

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@etchteam/stylelint-config@1.7.2',
npm warn EBADENGINE   required: { node: '^18 || ^20 || ^22' },
npm warn EBADENGINE   current: { node: 'v24.16.0', npm: '11.16.0' }
npm warn EBADENGINE }

What

  • Add ^24 to engines.node.
  • Add 24 to the CI lint matrix so support is actually exercised.

Verification

Ran npm ci + npm test (stylelint over ./test) locally on Node v24.16.0 — passes clean. The new matrix entry verifies it in CI.

feat: so semantic-release cuts a new minor that consumers can pin to.

Add Node 24 to the supported engines range and the CI lint matrix. Node 24 is the current LTS; stylelint and its dependencies run cleanly on it (verified locally on v24.16.0 and via the new matrix entry).
@mergify
mergify Bot requested review from DanWebb and JoshTheWanderer June 17, 2026 05:55

@JoshTheWanderer JoshTheWanderer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also drop 18 and 20, which are EOL now?

Comment thread .github/workflows/ci.yml Outdated
Comment thread package.json Outdated
Co-authored-by: Gavyn McKenzie <gavyn@etch.co>
@gavmck
gavmck requested a review from JoshTheWanderer June 17, 2026 09:50
@JoshTheWanderer
JoshTheWanderer merged commit f8d0a46 into main Jun 24, 2026
9 checks passed
@JoshTheWanderer
JoshTheWanderer deleted the feat/support-node-24 branch June 24, 2026 09:08
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants