Skip to content

perf: short-circuit identical address comparison #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobTheBuidler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: short-circuit identical address comparison #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eth_utils/address.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ def is_same_address(
"""
if not is_address(left) or not is_address(right):
raise ValueError("Both values must be valid addresses")
else:
return bool(to_normalized_address(left) == to_normalized_address(right))
if left == right:
return True
return bool(to_normalized_address(left) == to_normalized_address(right))


def to_checksum_address(value: AnyAddress | str | bytes) -> ChecksumAddress:
Expand Down
5 changes: 5 additions & 0 deletions tests/core/address-utils/test_address_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ def test_to_checksum_address(value, expected):
@pytest.mark.parametrize(
"address1,address2,expected",
(
(
"0x52908400098527886E0F7030069857D2E4169EE7",
"0x52908400098527886E0F7030069857D2E4169EE7",
True,
),
(
"0xc6d9d2cd449a754c494264e1809c50e34d64562b",
"0xc6d9d2cD449A754c494264e1809c50e34D64562b",
Expand Down