ENG-3555: Migrate SystemDataForm (history diff) to Ant Design#8239
Open
gilluminate wants to merge 2 commits into
Open
ENG-3555: Migrate SystemDataForm (history diff) to Ant Design#8239gilluminate wants to merge 2 commits into
gilluminate wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
gilluminate
requested review from
Kelsey-Ethyca and
lucanovera
and removed request for
a team
Migrate the read-only system history diff view from Chakra/Formik to
antd. Drop Formik entirely (the view is read-only) and read values
directly from the SelectedHistoryContext.
- SystemDataForm: replace Formik wrapper with Flex vertical
- SystemDataGroup: use fidesui Card with aligned header padding
- SystemData{TextField,Tags,Switch}: replace Chakra layout with Flex,
Typography, and Tag; move diff highlight styling into a CSS module
- Replace any[] in SystemDataTags with a TagValue union type
- Use symmetric Ant success bg/border tokens for highlightAfter
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gilluminate
force-pushed
the
gill/eng-3555/system-data-form-antd
branch
from
c109c6b to
b7a4035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3555
Description Of Changes
Migrate the read-only system history diff view from Chakra UI and Formik to Ant Design. The form is purely for display (no validation, no submit) so Formik is dropped entirely — values are read directly from
SelectedHistoryContextinstead of viauseField.The diff highlight styling (red "before" / green "after" with the arrow indicator) moves from inline Chakra props into a CSS module using Ant theme tokens. The card chrome is now
fidesuiCardwith the body padding zeroed so the field cells own their own spacing.Code Changes
clients/admin-ui/src/features/system/history/modal/SystemDataForm.tsx— replace theFormikwrapper with aFlex verticaland pass values via context.clients/admin-ui/src/features/system/history/modal/SystemDataGroup.tsx— use fidesuiCard(stringtitle+variant="outlined"); align header padding with field cell padding; delete the per-group SCSS module.clients/admin-ui/src/features/system/history/modal/fields/SystemDataTextField.tsx— replaceChakraVStack/ChakraFlex/ChakraTextwith antdFlexandTypography.Text; preserve the height-measurement workaround that keeps before/after rows aligned.clients/admin-ui/src/features/system/history/modal/fields/SystemDataTags.tsx— same migration; replaceany[]with aTagValue = string | { fides_key: string }union.clients/admin-ui/src/features/system/history/modal/fields/SystemDataSwitch.tsx— same migration; show a YES/NOTaginstead of a Chakra badge.clients/admin-ui/src/features/system/history/modal/fields/SystemDataField.module.scss— new module for the diff highlight classes; usescolor-error-bg/color-error-borderand the symmetriccolor-success-bg/color-success-borderAnt tokens.Steps to Confirm
SystemHistoryModalopens with the before/after diff.→arrow.processes_personal_data) — render as a YES/NO tag.SystemDataGroupcard header ("System details", "Privacy declarations", etc.) sits flush with the field labels (16px left padding).Pre-Merge Checklist
CHANGELOG.mdupdated