Skip to content

Vanisher bugfixes #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aurimaley wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Vanisher bugfixes #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions Kit/Repository/Interactables/Vanisher/init.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ local SHRINK_DIRECTION_OFFSETS = {
Center = Vector3.zero,
Top = Vector3.yAxis,
Bottom = -Vector3.yAxis,
Front = Vector3.zAxis,
Back = -Vector3.zAxis,
Front = -Vector3.zAxis,
Back = Vector3.zAxis,
Left = -Vector3.xAxis,
Right = Vector3.xAxis,
}
Expand Down Expand Up @@ -105,6 +105,13 @@ function Vanisher.Run(scope: _T.Scope, utility: _T.Utility)
local vanisherChildren: { Instance } = if vanisherObject:IsA("BasePart")
then { vanisherObject }
else vanisherObject:GetChildren()

--> Fix a silly issue
local invertZDirections: boolean
do
local coVersion = utility.ClientObjects.getCOVersion(vanisherConfig)
invertZDirections = not utility.ClientObjects.isVersionOrHigher(coVersion, "v6.1.4")
end
---------------

for _, part in vanisherChildren do
Expand Down Expand Up @@ -319,19 +326,21 @@ function Vanisher.Run(scope: _T.Scope, utility: _T.Utility)
local direction = SHRINK_DIRECTION_OFFSETS[configuration.ShrinkDirection]
local startSize = vanisher.Size
local endSize = Vector3.zero
local relativeOffset = CFrame.identity
local shrinkPartCFrame = vanisher.CFrame
if configuration.ShrinkDirection ~= "Center" then
local offset = (0.5 * startSize) * direction
if direction.X ~= 0 then
endSize = Vector3.new(0, startSize.Y, startSize.Z)
relativeOffset = CFrame.new(-offset)
elseif direction.Y ~= 0 then
relativeOffset = CFrame.new(offset)
endSize = Vector3.new(startSize.X, 0, startSize.Z)
elseif direction.Z ~= 0 then
relativeOffset = CFrame.new(-offset)
if invertZDirections then
direction *= -1
end
endSize = Vector3.new(startSize.X, startSize.Y, 0)
end

local offset = (-0.5 * direction) * startSize
shrinkPartCFrame *= CFrame.new(offset)
end

if configuration.ShrinkToZero then
Expand All @@ -347,7 +356,7 @@ function Vanisher.Run(scope: _T.Scope, utility: _T.Utility)

-- To support moving for unanchored objects
local vanisherConnection = cleanupScope:add(RunService.PreRender:Connect(function()
shrinkPart.CFrame = vanisher.CFrame * relativeOffset * CFrame.new((shrinkPart.Size * 0.5) * direction)
shrinkPart.CFrame = shrinkPartCFrame * CFrame.new((shrinkPart.Size * 0.5) * direction)
end))

local tween = startTween(shrinkPart, { Size = endSize })
Expand Down