Ensured that TaskProcessor used in connection pools clears pending tasks#186
Open
oskardudycz wants to merge 5 commits into
Open
Ensured that TaskProcessor used in connection pools clears pending tasks#186oskardudycz wants to merge 5 commits into
oskardudycz wants to merge 5 commits into
Conversation
oskardudycz
force-pushed
the
task_processor_deadlocks
branch
from
2646978 to
5bf6e90
Compare
TaskProcessor.stop() cleared its queue with this.queue.length = 0 without rejecting the captured promises. Anyone waiting on a queued task hung for ~24 days until the fallback deadline fired. Triggered in emmett when one consumer's pool.close() orphaned the other 9 consumers' pending writes.
oskardudycz
force-pushed
the
task_processor_deadlocks
branch
from
5bf6e90 to
8b70f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskProcessor.stop()cleared its queue withthis.queue.length = 0without rejecting the captured promises.Anyone waiting on a queued task hung for ~24 days until the fallback deadline fired. Triggered in Emmett when one consumer's
pool.close()orphaned the other multiple consumers' pending writes.