Skip to content

Prepare v4.0.2#84

Open
ignaciogros wants to merge 6 commits into
mainfrom
83-prepare-v402
Open

Prepare v4.0.2#84
ignaciogros wants to merge 6 commits into
mainfrom
83-prepare-v402

Conversation

@ignaciogros

@ignaciogros ignaciogros commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator
  • Review and complete the Spanish (es) translation.
  • Placeholder translations for newly introduced strings in incomplete translations.
  • Reorder lang strings for ca, eu, gl, es to match en key order.
  • New agent skill to generate CHANGELOG draft.
  • v4.0.2 CHANGELOG.

Moodle Playground Preview

The changes in this pull request can be previewed and tested using a Moodle Playground instance.

Preview in Moodle Playground

ℹ️ The eXeLearning editor is fetched from the shared release and unpacked into the plugin when the playground boots, so the first load may take a few extra seconds. ELPX upload, viewer and preview work normally.

@ignaciogros ignaciogros requested a review from erseco June 28, 2026 14:00
@ignaciogros ignaciogros linked an issue Jun 28, 2026 that may be closed by this pull request
@erseco

erseco commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Hi @ignaciogros 👍

I reviewed this release-prep PR and it looks good to merge — approving. Nice clean work on the translations.

What I checked

  • php -l passes on ca/es/eu/gl; no duplicate keys; every language has exactly 586 keys, matching en, and the key sets are identical to en.
  • {$a} placeholders are preserved in all changed strings.
  • The removed deleteattemptcheck is correct cleanup — that key isn't in en either (orphan), so nothing is lost.
  • Brought the stack up (make clean + make up, Moodle on localhost) and exercised the pages that render the changed strings in Spanish: the plugin settings page (the editormode → "Modo del editor" change and the reworded apidebugmask both render correctly, no raw placeholders), saving settings works with no package-template file present, and the styles manager (/mod/exescorm/admin/styles.php) renders the whole new styles* string block cleanly.

Minor follow-ups (non-blocking):

  1. .agents/skills/changelog/SKILL.md — the YAML frontmatter isn't a valid ------ block (blank line after the opening fence + a long dash line instead of a closing ---). Some skill loaders won't parse the name/description, so the skill may not load. Worth tidying to plain --- fences.
  2. lang/eu/exescorm.php (stylesuploaded_hint, stylesbuiltin_hint) — typo "editiretik" → should be "editoretik".
  3. lang/gl/exescorm.php (stylesuploaded_hint) — Castilianisms "ocultarlos/borrarlos" → Galician "ocultalos/borralos"; and stylesdelete_confirm uses the Spanish "¿" which the Galician normative omits.

None of these block the release — #2 (the Basque typo) is the one most worth fixing first.

A detailed review report (PDF, with the full verification matrix and screenshots) is attached to this PR.

pr84-review.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare v4.0.2

2 participants