Fix null entry on transform build spend-ledger rows - #284
Open
lesbass wants to merge 1 commit into
Open
Conversation
_transform build_ writes its spend directly to the ledger through _record_build_spend, bypassing the cost gate's _append which always includes entry: kind. As a result, every transform build row carried entry: null while maintain check and explore query rows correctly carried entry: settlement. Add entry: settlement to the dict passed to append_spend_log so all settlement rows are self-describing and filtering on entry == settlement produces the full picture. Fixes exmergo#277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277.
Problem
transform buildwrites its spend directly to.dex/spend.jsonlthrough_record_build_spend, bypassing the cost gate's_appendwhich always includes"entry": kind. As a result, everytransform buildrow carried"entry": nullwhilemaintain checkandexplore queryrows correctly carried"entry": "settlement".Filtering on
entry == "settlement"therefore drops everytransform buildrow, which is the single largest spender in a normal session.Fix
Add
"entry": "settlement"to the dict passed toappend_spend_login_record_build_spendso all settlement rows are self-describing.Files changed
packages/dex-core/src/exmergo_dex_core/transform/commands.py: +1 lineVerification
123 passed, 7 skipped.