SCRUM-1068-explore profile flags a boolean-shaped column with >2 values - #326
Merged
Conversation
marcociav-exmergo
approved these changes
Aug 19, 2026
marcociav-exmergo
left a comment
Member
There was a problem hiding this comment.
Very nice, thank you @emnarahmouni-exmergo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #218.
A column named like a two-valued flag (is_, has_, *_flag, *_yn, *_ind) can hold more than two distinct non-null values, a mixed-encoding defect that went unreported: raw_workspaces.primary_ws_yn on the public ADE-bench helixops_saas.duckdb holds five values under a name that promises two.
explore profile now emits a data-quality observation when a boolean-ish name and a non-null distinct count above two coincide.
Where the value domain (#203) is already known for that column, the observation names each encoding with its count; where it's not (the column failed one of that feature's own eligibility gates), it still fires on the count alone, since not being able to name the values is not evidence there are only two of them.
A genuinely BOOLEAN-typed column is excluded outright, whatever its name it cannot hold more than two values by construction.
Deliberately does not try to distinguish a data-quality defect from a genuine third state; the tool can't make that call, so it names what it found and lets the caller decide (a required acceptance criterion, not an oversight).