SCRUM-1070-explore: propose joins from measured value overlap - #330
Open
emnarahmouni-exmergo wants to merge 1 commit into
Open
SCRUM-1070-explore: propose joins from measured value overlap#330emnarahmouni-exmergo wants to merge 1 commit into
emnarahmouni-exmergo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes : #220
explore relationships/explore map --infer-by-overlap(#220, depends on #208): proposes a join from measured value overlap when no column name gives inference anything to work with (acct_id_fktows_id, or a source that names every keyid). Value overlap is strictly strongerevidence than a name, since a name is only ever a proxy for it.
How it works
explore map's notes even when off, so the option is discoverable without--help.--verifyalready uses (authored once, transpiled per dialect); only a candidate clearing a strict containment ceiling is proposed, the rest are dropped outright.--verifyuses.--verifyon the same merged edge set, deferring entirely if verify's own checkpoint is still pending, so at most one checkpoint is ever in flight.RelationshipKind.OVERLAP_INFERRED, distinguishable from a declared or name-derived edge in both the cache and the envelope.Bug found and fixed during manual testing
An overlap-derived edge vanished on the very next plain run, since nothing else ever rediscovers it the way a declared edge (re-read from
the dbt project every run) or a name-inferred one (re-derived from cheap metadata every run) does. Fixed by carrying a prior overlap-derived edge forward unconditionally as long as both endpoints are still known objects. That fix also closes a redundancy: a later sweep now skips a pair it already confirmed instead of re-probing (and re-paying for) it.
Verified manually end to end against a real DuckDB pair with zero naming signal: discovery, persistence across a plain re-run, and idempotency on a repeated sweep all confirmed.