Issue-26 - Accept Explicit Project Id.#27
Merged
expl merged 7 commits intoMar 25, 2026
Conversation
- [x] Added a new method live_with_project_id to allow implementers to appropriately select a dedicated project id. - [x] Updated README.md accordingly.
- [x] Added an example in the examples/ folder
Contributor
Author
expl
reviewed
Mar 24, 2026
expl
left a comment
expl
left a comment
Owner
There was a problem hiding this comment.
Thank you for your PR and sorry for not replying promptly.
Some feedback:
- A full example just to demonstrate a new constructor is probably not required.
- Due to an oversight in my implementation, this change breaks the
id_token_verifier()andcookie_token_verifier()implementation on the sameimplblock, just assigningproject_idtoself.project_id.clone()is sufficient and would not break with your change, do you mind including this in your PR?
- [x] Removed explicit project id example as per PR comment in https://github.com/expl/rs-firebase-admin-sdk/pull/27\#pullrequestreview-3997213998
- [x] Updated id_token_verifier() and cookie_token_verifier() to use self.project_id instead of asynchronously getting the project id from credentials. This addresses PR comment https://github.com/expl/rs-firebase-admin-sdk/pull/27\#pullrequestreview-3997213998
Contributor
Author
@expl 👍
Addressed in 09ca552
Great catch! Addressed in 607ae38 Ready for review |
Thank you, The last request from me is to keep the function signatures the same without removing the |
- [x] Reverted functions to async
Contributor
Author
Oops, should have anticipated that.. Updated in b1d8971 |
expl
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When Firebase and infrastructure run in separate GCP projects,
GOOGLE_CLOUD_PROJECTis already taken by the infrastructure project.This pull request adds a constructor as reported in Issue 26 that accepts the Firebase project ID directly, bypassing env var and credential header resolution adequately.
There are no breaking changes.2 breaking changes have been reported and fixed.Changes
lib/src/lib.rs— newApp::live_with_project_id(project_id: &str)onApp<AccessTokenCredentials>README.md— usage example and motivation for the new constructorexamples/explicit_project_id/— runnable example