fix: add SSL mode support to MySQL/MariaDB connections (#36505)#1534
Open
hidekoji wants to merge 5 commits into
Open
fix: add SSL mode support to MySQL/MariaDB connections (#36505)#1534hidekoji wants to merge 5 commits into
hidekoji wants to merge 5 commits into
Conversation
- Add sslMode param to queryMySQL (default "") - Wire sslMode through executeGenericQuery → queryMySQL - Add sslMode to getDBConnection/clearDBConnection cache key for mysql/aurora - Map PostgreSQL-style SSL mode strings to RMariaDB constants (SSL_MODE_*) - Refactor mysql/aurora connection creation to do.call for clean conditional args
hidekoji
commented
Jul 2, 2026
hidekoji
marked this pull request as ready for review
July 2, 2026 06:42
kei51e
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds full SSL mode support to MySQL/MariaDB connections in the R backend.
Changes
R/system.RqueryMySQL: AddedsslMode = ""parameter; passes it togetDBConnectionandclearDBConnectionexecuteGenericQuery: ForwardssslModetoqueryMySQL(was silently dropping it)getDBConnectionmysql/aurora branch:sslModeto cache key (prevents SSL-mode collision in connection pool)switch()mapping PostgreSQL-style UI strings → RMariaDB constants:"disable"→SSL_MODE_DISABLED"allow"/"prefer"→SSL_MODE_PREFERRED"require"→SSL_MODE_REQUIRED"verify-ca"→SSL_MODE_VERIFY_CA"verify-full"→SSL_MODE_VERIFY_IDENTITYdo.call(RMariaDB::dbConnect, ...)with conditionaltz_args,ca_args,mode_argsto avoid duplicating branchesclearDBConnectionmysql/aurora branch: AddedsslModeto cache key (matchesgetDBConnection)How to Test
require(orverify-cawith a CA file)