Skip to content

feature: labeledvideodataset returns clip start and end - #78

Open
miraodasilva wants to merge 1 commit into
facebookresearch:mainfrom
miraodasilva:feat/clipstartend
Open

feature: labeledvideodataset returns clip start and end#78
miraodasilva wants to merge 1 commit into
facebookresearch:mainfrom
miraodasilva:feat/clipstartend

Conversation

@miraodasilva

Copy link
Copy Markdown

As suggested in my issue #59 by @kalyanvasudev . I've been using the repo with this change for a while now, never had any issues.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @miraodasilva!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2021
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@dasturge

Copy link
Copy Markdown

would like to see this get merged, anything holding it back?

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.88%. Comparing base (e236b0b) to head (27dec8d).
⚠️ Report is 109 commits behind head on main.

Files with missing lines Patch % Lines
pytorchvideo/data/labeled_video_dataset.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         122      122           
  Lines        7442     7442           
=======================================
  Hits         7061     7061           
  Misses        381      381           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants