fix: register onSend writer even when hook is false#360
Open
0XFF-96 wants to merge 1 commit into
Open
Conversation
Previously the onSend handler that flushes queued cookies to the Set-Cookie header was gated by the same `if (hook)` block as the parsing hook, so registering the plugin with `hook: false` made reply.setCookie() a silent no-op. The docs scope `hook` to cookie parsing only, so the writer should be registered unconditionally. It already early-returns when no cookies were queued, so this is a no-op unless setCookie is used. Adds a regression test.
climba03003
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the onSend handler that flushes queued cookies to the Set-Cookie header was gated by the same
if (hook)block as the parsing hook, so registering the plugin withhook: falsemade reply.setCookie() a silent no-op. The docs scopehookto cookie parsing only, so the writer should be registered unconditionally. It already early-returns when no cookies were queued, so this is a no-op unless setCookie is used.Adds a regression test.
Issue Link:#359
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct