SECURITY-169-API-38: close train state#2922
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 446cc2e070
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "remote_branch_deleted": true, | ||
| "repo": "fap-api", | ||
| "status": "in_progress", | ||
| "status": "merged", |
There was a problem hiding this comment.
This line marks SECURITY-169-API-38 as merged and also records pr_url/merged_at, but the same object still has "commit_sha": null above even though the new event names the squash merge SHA 74eb8ed8e2beac7cbd5b46d0b1df711d64b5dc32. Any PR-train runner or audit that uses commit_sha as merge evidence cannot verify the dependency before SECURITY-169-API-39, so please populate the top-level commit_sha when marking the item merged.
Useful? React with 👍 / 👎.
| }, | ||
| "cms_mutation": false, | ||
| "commit_sha": null, | ||
| "commit_sha": "4a430df941c9574300a268184b3fcacca4ba97b4", |
There was a problem hiding this comment.
This SECURITY-169-API-38 closeout also writes a commit SHA into the unrelated SECURITY-103-API-04 entry while that entry remains status: planned with no pr_url, merged_at, or execution event. In the checked state file this makes SECURITY-103-API-04 the only planned item with a commit_sha, leaving the SECURITY-103 train in an ambiguous partially-executed state for whoever resumes it; revert this field or record the full API04 transition in its own scoped update.
Useful? React with 👍 / 👎.
1 participant
What changed
Why
Implementation and post-merge revalidation are complete; durable ledger closeout is required before API39.
Validation
git diff --checkDeferred items