fix: File::Temp cwd for pathless templates (Config::JSON jcpan)#683
Merged
fix: File::Temp cwd for pathless templates (Config::JSON jcpan)#683
Conversation
Perl's File::Temp::tempfile($template) creates files in the current directory when the template has no directory component. The Java implementation incorrectly used java.io.tmpdir / TMPDIR for that case, so relative globs (e.g. Config::JSON's glob '*.include.conf') did not see include files. Align createTempFile/createTempDir with stock Perl. Fixes jcpan -t Config::JSON (t/Wildcard.t). Generated with [Cursor](https://cursor.com) Co-Authored-By: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File::TempJava backend (FileTemp.java) so pathless templates (e.g.XXXXX,fooXXXXXX) create files under the process current working directory, matching stock Perl (perldoc File::Temp:tempfile($template)uses the current directory).java.io.tmpdir, so files were invisible to cwd-relativeglobpatterns.Verification
./jcpan -t Config::JSON— PASS (includingt/Wildcard.t, which usestempfile+glob '*.include.conf').make— PASS.Context
Config::JSON expands includes with
map { glob $_ } @{ $self->get('includes') || [] }. Include paths fromFile::Tempmust live where that glob can see them.