Fix MakeMaker autosplit staging for Class::MethodMaker#691
Merged
Conversation
Teach the PerlOnJava MakeMaker shim to stage .pm files like upstream ExtUtils::MakeMaker by making pm_to_blib depend on source files, emitting WriteMakefile depend rules, and running AutoSplit for staged and installed modules. Preserve single-quoted substitution replacement delimiters while parsing s/// forms so Class::MethodMaker's generator can produce its component .pm files under strict. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pmfiles throughpm_to_blibdependencies and honorWriteMakefile dependrulesAutoSplitwhen copying staged and installed.pmfiles soauto/*/autosplit.ixis producedstrictTesting
timeout 1200 make > /tmp/make_class_methodmaker.log 2>&1; printf 'EXIT: %s\n' $? >> /tmp/make_class_methodmaker.log->EXIT: 0timeout 60 ./jperl src/test/resources/unit/regex/regex_single_quote_substitution.t > /tmp/regex_single_quote_substitution.log 2>&1; printf 'EXIT: %s\n' $? >> /tmp/regex_single_quote_substitution.log->EXIT: 0timeout 600 ./jcpan -t Class::MethodMaker > /tmp/class_methodmaker_after.log 2>&1; printf 'EXIT: %s\n' $? >> /tmp/class_methodmaker_after.log-> autosplit generation now succeeds; remaining failures are from the missing Java XS implementation forClass::MethodMaker::set_sub_name