feat(host): deliver //action:* via an on_action callback (#25)#27
Merged
Conversation
Board-initiated host actions (//action:pause/paused/resume/cancel/prompt — M600, runout, LCD pause) were parsed as MarlinResponseKind.ACTION then silently dropped in _await_terminal (non-terminal, no collect). A host that cannot see them can't react. Add an opt-in on_action callback fired whenever an ACTION line is seen during send()/query()/stream(), before the collect fall-through. Delivery only — no forced policy; auto-honoring pause/resume/cancel can follow. Covered by FakeTransport unit tests (send + stream paths).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25.
Board-initiated
//action:messages (M600 filament change, runout, LCD pause →//action:pause/paused/resume/cancel/prompt) were parsed (MarlinResponseKind.ACTION) then dropped in_await_terminal(non-terminal, nocollect). Add an opt-inon_actioncallback fired whenever an ACTION line is seen duringsend()/query()/stream().Delivery only (app-neutral, no forced policy). Needed by the fiberpath machine cutover (fiberpath/fiberpath#195). 3 FakeTransport tests (send + stream); 115 pass,
just checkclean. (A real//actionneeds a powered M600/runout scenario — deferred to a 12V hardware session.)