chore(deps): clean up Python dependency declarations - #116
Open
jimlee2048 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moviepy,sounddevice, andpdf2imagedependenciesimageio[ffmpeg]andscikit-learndirectly instead of relying on transitive installationsrequirements.txtandpyproject.tomlconsistentWhy
The project no longer imports MoviePy or pdf2image, and sounddevice is not used by the current source code.
MoviePy 1.0.3 also requires
decorator<5.0, which conflicts with thedecorator>=5.2.1requirement used by librosa 1.x. Although dependency resolvers may silently install an older librosa release, the stale MoviePy dependency unnecessarily restricts the shared ComfyUI environment.FL_SaveWebMimports imageio and uses its ffmpeg backend, whileFL_PixelArtimports scikit-learn directly. Declaring these packages explicitly avoids depending on unrelated transitive dependencies.Impact
This changes dependency declarations only. No node interfaces or runtime behavior have been changed.
Fresh installations will no longer install the unused packages, and both supported dependency manifests now produce the same environment.
Validation
requirements.txtwith uv for Python 3.11 and 3.13pyproject.tomlwith uv for Python 3.11 and 3.13AI-assisted contribution: OpenAI Codex (GPT-5.6-sol) assisted with the dependency audit, implementation, validation, and PR documentation.