Skip to content

chore(deps): clean up Python dependency declarations - #116

Open
jimlee2048 wants to merge 1 commit into
filliptm:mainfrom
jimlee2048:codex/cleanup-python-dependencies
Open

chore(deps): clean up Python dependency declarations#116
jimlee2048 wants to merge 1 commit into
filliptm:mainfrom
jimlee2048:codex/cleanup-python-dependencies

Conversation

@jimlee2048

Copy link
Copy Markdown

Summary

  • remove unused moviepy, sounddevice, and pdf2image dependencies
  • declare imageio[ffmpeg] and scikit-learn directly instead of relying on transitive installations
  • remove duplicate PDF dependency entries
  • keep requirements.txt and pyproject.toml consistent

Why

The project no longer imports MoviePy or pdf2image, and sounddevice is not used by the current source code.

MoviePy 1.0.3 also requires decorator<5.0, which conflicts with the decorator>=5.2.1 requirement used by librosa 1.x. Although dependency resolvers may silently install an older librosa release, the stale MoviePy dependency unnecessarily restricts the shared ComfyUI environment.

FL_SaveWebM imports imageio and uses its ffmpeg backend, while FL_PixelArt imports scikit-learn directly. Declaring these packages explicitly avoids depending on unrelated transitive dependencies.

Impact

This changes dependency declarations only. No node interfaces or runtime behavior have been changed.

Fresh installations will no longer install the unused packages, and both supported dependency manifests now produce the same environment.

Validation

  • resolved requirements.txt with uv for Python 3.11 and 3.13
  • resolved pyproject.toml with uv for Python 3.11 and 3.13
  • confirmed both manifests contain the same direct dependencies and version constraints
  • confirmed the removed packages are no longer referenced by the project

AI-assisted contribution: OpenAI Codex (GPT-5.6-sol) assisted with the dependency audit, implementation, validation, and PR documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant