Skip to content

fix(sinopac): fetch contracts on demand when Stocks lookup misses #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koreal6803 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sinopac): fetch contracts on demand when Stocks lookup misses #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion brokers/sinopac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,16 @@ def _get_contract(self, stock_id: str) -> Any:
pass
stocks = getattr(getattr(self.api, "Contracts", None), "Stocks", None)
if stocks is not None:
return stocks[stock_id]
try:
contract = stocks[stock_id]
except KeyError:
contract = None
if contract is not None:
return contract
# Contracts are not populated yet. This happens on shioaji < 1.7 where
# login() used fetch_contract=False and no contracts were downloaded, so
# the lookup above misses even for actively traded stocks. Fetch on
# demand and retry instead of surfacing a bare "Contract not found".
self.api.fetch_contracts(contract_download=sj.constant.SecurityType.Stock)
return self.api.Contracts.Stocks[stock_id]

Expand Down