Link FormSubmission to Input by foreign key (#639) - #651
Merged
marcvergees merged 1 commit intoAug 7, 2026
Merged
Conversation
marcvergees
approved these changes
Aug 7, 2026
marcvergees
merged commit Aug 7, 2026
e7b63a3
into
fireform-core:development-approach-b
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #639.
Adds a nullable input_id foreign key on FormSubmission referencing Input, so a submission
links to the Input it was filled from instead of only duplicating the transcript.
existing Extraction.input_id style. input_text kept.
SQLite (tests) and Postgres — a plain ALTER-add-constraint isn't supported on SQLite.
Round-trips cleanly (upgrade → downgrade → re-upgrade).
fill_form_task (as a string, per the Celery serialization convention already used in
transcribe.py) and jobs.py passes it in.
read it. Migrating those readers to the FK and dropping input_text is a deferred
follow-up (noted in the migration docstring).
@marcvergees @vharkins1 @chetanr25