Fix agent websocket URL resolution and connection hang - #291
Merged
Conversation
PiotrWodecki
requested changes
Jul 22, 2026
czerwiukk
force-pushed
the
fix/agent-websocket-url
branch
from
July 22, 2026 13:29
7e280af to
49a9e4a
Compare
PiotrWodecki
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
createAgentcould fail to connect on some clusters, and when the agent socket returned a 404 the call hung forever.POST /room/:id/peerreturnspeer_websocket_url; when present, the agent now connects using it (swapping the peer socket suffix for the agent one) instead of always deriving/socket/agent/websocketfrom the Fishjam connect URL. Falls back to the previous derivation when the field is absent, so older deployments keep working.awaitConnected()now rejects on a pre-open socket close (e.g. a 404 during the handshake) instead of hanging indefinitely.Why separate from the release PR
Split out of the 0.29.0 release PR (#290) so it can be reviewed and merged to
mainon its own.Tests
Added
tests/agent.test.tscovering URL resolution (suffix swap, protocol normalization, path-prefix preservation, both fallbacks) and connect/resolve/reject behavior.yarn typecheckand the new tests pass.🤖 Generated with Claude Code