Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new server notification message to expose recording lifecycle transitions to webhook consumers (dashboard), aligning the protobuf schema, generated Elixir bindings, and rendered docs.
Changes:
- Introduces
ServerMessage.RecordingStatusChangedwithStatusenum (FINISHED/AVAILABLE/FAILED) plusrecording_idandmetadata. - Adds
recording_status_changedas a newServerMessageoneof contentvariant (tag34). - Regenerates/updates Elixir protobuf modules and the markdown docs to include the new message and enum.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fishjam/server_notifications.proto | Adds RecordingStatusChanged message + ServerMessage oneof variant for recording status transitions. |
| fishjam_protos/lib/fishjam/server_notifications.pb.ex | Updates generated Elixir protobuf definitions to include the new enum/message and field. |
| doc/docs.md | Updates generated documentation/TOC to document the new notification and enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
RecordingStatusChangedtoServerMessageso Fishjam can push recording lifecycle transitions (finished/available/failed) with the recording'smetadatato the dashboard webhook, per ADR-0048.No
ACTIVEvalue — recordings are born active (that's the create response, not a transition).Part of FCE-3518.