FCE-3643: Add SDK impact checklist to PR template - #60
Open
MiloszFilimowski wants to merge 1 commit into
Open
Conversation
Protos are no longer bumped by the release automation. The author of a protos change is responsible for bumping the protos version and the SDKs that consume it.
MiloszFilimowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an SDK impact section to the PR template with checkboxes for bumping the protos version and the SDKs that consume it.
Motivation and Context
Protos are no longer bumped as part of the release cycle — the release-automation workflow no longer creates protos release PRs (fishjam-cloud/release-automation#24). The author of a protos change is now responsible for bumping the protos version and updating the consuming SDKs, and the PR template checklist makes that responsibility explicit.
Related: fishjam-cloud/internal-docs#118 removes the Protos section from the release checklist.