Fix invisible styled text input on Web - #191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebGPU text input could accept edits and update retained state while rendering no glyphs when an application requested a font family that was not packaged into the Web build. The software renderer already fell back to Fission default typography, but the Vello rich-text path did not. This change makes authored font stacks consistently terminate in the registered Fission default face, so a missing custom font degrades typography instead of making entered text invisible.
The Web smoke app now includes a Worka-shaped, borderless verification-code input inside a ZStack with large type, line height, letter spacing, numeric formatting, and one-time-code metadata. Its browser test performs a real edit and compares pixels inside the input bounds, proving that visible glyphs were painted rather than merely checking retained state or semantics.
Web text-hint diagnostics now preserve their actual warning severity in the browser console. Disabling autocorrection also satisfies disabled smart-dash and smart-quote behavior, so that supported combination no longer emits a diagnostic. Unsupported finer-grained combinations remain visible as console warnings without being misreported as application errors.
Fixes #189
Fixes #190