Fix public models and add supported vars - #39
Open
fivetran-avinash wants to merge 10 commits into
Open
Conversation
fivetran-avinash
added
docs:ready
| - [`apple_store__subscription_report`](https://fivetran.github.io/dbt_app_reporting/#!/model/model.apple_store.apple_store__subscription_report) | ||
| - [`google_play__finance_report`](https://fivetran.github.io/dbt_app_reporting/#!/model/model.google_play.google_play__finance_report) | ||
| - Adds support for configuring individual `apple_store` and `google_play` package-level variables (e.g. `apple_store__subscription_events`) directly from Quickstart. | ||
| - Adds table variables for non-essential connector source tables (`app_crash_daily`, `stats_store_performance_traffic_source`) so a missing optional source no longer blocks downstream Quickstart models. |
Contributor
There was a problem hiding this comment.
This last one should be Under the Hood
Also might wanna specify that these are system-only variables
Comment on lines
+37
to
+40
| _fivetran_quickstart_app_crash_daily: | ||
| - app_crash_daily | ||
| _fivetran_quickstart_stats_store_performance_traffic_source: | ||
| - stats_store_performance_traffic_source |
Contributor
There was a problem hiding this comment.
Could you include the source name in the variable name so it's easy to tell which is from Apple and which is from Google?
Contributor
Author
There was a problem hiding this comment.
Ah good catch.
…pp_reporting into fix/public-models
fivetran-jamie
approved these changes
Aug 4, 2026
fivetran-avinash
added
docs:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog