Distributed tracing: traceId in logs, X-Trace-Id header, Kafka traceparent - #1764
Open
andriikachur wants to merge 6 commits into
Open
Distributed tracing: traceId in logs, X-Trace-Id header, Kafka traceparent#1764andriikachur wants to merge 6 commits into
andriikachur wants to merge 6 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…arent propagation) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…racing # Conflicts: # openframe-config-core/src/main/resources/logging/shared-logback-includes-logfmt-shortened.xml # openframe-config-core/src/main/resources/logging/shared-logback-includes-logfmt.xml # openframe-config-core/src/main/resources/logging/shared-logback-includes.xml
Adds TracedExecutorFactory in openframe-core and uses it for the tool-install executor (client-core) and the notification channel executor (data-nats). Both created plain virtual-thread executors, so traceId/spanId were lost as soon as work crossed the @async boundary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Foundation for distributed tracing (log correlation via W3C trace ids) across OpenFrame:
openframe-config-core/logging/): addedtraceId=%X{traceId:-} spanId=%X{spanId:-}to the logfmt console patterns (and[%X{traceId:-}]to the plain pattern). Renders empty until services get a tracing bridge — safe no-op.TraceIdResponseHeaderFilterinopenframe-gateway-service-core: returns anX-Trace-Idresponse header so a failing request can be looked up in Loki without server access.openframe-data-kafka:KafkaTemplate+ listenerContainerPropertiesobservation enabled, sotraceparentpropagates through Kafka records.No exporter anywhere — spans are created and dropped; this is log-correlation only.
Testing
TraceIdResponseHeaderFilterTest(2 tests),OssTenantKafkaAutoConfigurationTest(2 tests) — green.🤖 Generated with Claude Code