fix(video-bites): show a card skeleton before the media mounts - #1785
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix(video-bites): show a card skeleton before the media mounts#1785posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
VideoHoverPreviewSurface painted a bare bg-ods-card rectangle while the IntersectionObserver mount gate had not yet reported the card as near the viewport. On the flamingo.run homepage carousel this showed as empty dark boxes during a fast marquee glide or a chevron jump, because the observer runs async and lags a fast scroll. The un-mounted branch now renders real card chrome: the poster (a lazy next/image, so off-screen cards fetch nothing) plus the center play glyph, or an animated shimmer when a bite has no thumbnail. An ungated card reads as a card instead of a flat dark box. Generated-By: PostHog Desktop Task-Id: fae7cfe4-7c8e-4c70-aa31-0a4cf1fe6805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VideoHoverPreviewSurfacegates its media on anIntersectionObservermount signal (playerMounted). Until that fires, the un-mounted branch rendered a barebg-ods-cardrectangle: no poster, no play glyph.Change
next/image(off-screen cards fetch nothing) plus the center play glyph;Scope notes
multi-platform-hub/lib/data/featured-video-bites-utils.ts) already carriesthumbnail_urlfor every bite that has one (it spreads the full bite). A bite with no thumbnail now shows the shimmer skeleton rather than a black box.Test plan
thumbnail_urlshows an animated shimmer, not black.Why
The homepage hero carousel is the first thing a flamingo.run visitor sees; empty dark boxes read as broken even though nothing functional fails. This is polish on a high-visibility, shared surface.
Created with PostHog Desktop from this inbox report.