feat: continuous-build mode#458
Merged
Merged
Conversation
julio4
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
julio4
force-pushed
the
reapply-async-payload-builder
branch
from
d83dffd to
cbe4b7a
Compare
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
from
895a4a2 to
d45b137
Compare
avalonche
reviewed
Apr 16, 2026
avalonche
reviewed
Apr 16, 2026
3 tasks
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
from
d45b137 to
3435df5
Compare
akundaz
reviewed
Apr 20, 2026
Collaborator
|
did you push your changes correctly? don't see code changes for comments |
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
2 times, most recently
from
932b00a to
88c1026
Compare
akundaz
reviewed
Apr 28, 2026
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
5 times, most recently
from
9fc7ebc to
8a3b18e
Compare
akundaz
previously requested changes
May 6, 2026
Comment on lines
+58
to
+68
| _ = deps.payload_cancel.cancelled() => { | ||
| Self::record_cancellation_reason(self.metrics(), deps.payload_cancel, deps.span); | ||
| self.record_flashblocks_metrics( | ||
| &interval.base_ctx, | ||
| &interval.base_fb_state, | ||
| &interval.base_info, | ||
| target_flashblocks, | ||
| deps.span, | ||
| ); | ||
| return Ok(()); | ||
| } |
Contributor
There was a problem hiding this comment.
payload_cancel is triggered when we receive the getPayload call, right? I figured we could publish the last flashblock then as well but here you're just exiting the loop. Is it not possible to do that? We would end up solving the race with ending block building and sending the last flashblock if possible
Member
Author
There was a problem hiding this comment.
payload_cancel is triggered when one of these fire: getPayload received, payload deadline reached, new FCU received.
I assumed that last trigger should always arrive before getPayload, but I agree with you this would be a nice improvement to submit last flashblock here if it's not the case.
Contributor
There was a problem hiding this comment.
definitely, i think leveraging PayloadJobCancellation would be a good idea
Member
Author
There was a problem hiding this comment.
Yes but let's do this as a follow up
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
3 times, most recently
from
64fa2f5 to
e5e6711
Compare
akundaz
reviewed
May 9, 2026
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
4 times, most recently
from
b1e6208 to
83fd70d
Compare
avalonche
approved these changes
Jun 2, 2026
julio4
force-pushed
the
feat/continuous-flashblock-build
branch
from
83fd70d to
071d2eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds a continuous flashblock building mode (under
--flashblocks.continuous-buildflag) that pre-seals candidates between scheduler triggers, so the best block is ready for instant publish when the timer fires.