fix(continuous): warn-only payload-channel sends#535
Open
julio4 wants to merge 1 commit into
Open
Conversation
…tinuous mode In continuous mode, `publish_candidate` was treating a full `built_fb_payload_tx` channel as a fatal error via `?`, which killed the entire payload job whenever the payload handler stalled (e.g. on a slow p2p peer). The per-trigger path in `notify_built_payload` has always treated the same condition as warn-and-continue. This fix replaces the fatal `try_send` / partial-warn pattern with a call to the existing `notify_built_payload` (widened to `pub(crate)`) and corrects the publish ordering to match the old path: ws publish → send_replace → notify_built_payload → timing metric. The now-dead `built_fb_payload_tx` and `built_payload_tx` accessor methods are removed; all callers are consolidated into `notify_built_payload`.
akundaz
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse
notify_built_payloadin continuouspublish_candidate+ warn built_fb_payload_tx instead of propagating error