feat: add conversation notifications - #1223
Draft
3r01 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhauls notifications to use android's conversations API
Groups mention notifications by channel
Groups whisper notifications by sender, displays recent messages from that sender together
Uses the channel profile picture as the conversation icon and the sender's profile picture for messages.
Tapping a mention notification opens the channel at that message if it is still in history. Tapping a whisper notification opens the whispers UI with that sender selected.
Notifications are cleared when their channel or the whispers sheet is visible.
Screenshots
Leaving this in draft to invite your opinion, as it is a large change and I am still testing it on my fork.