Skip to content

feature/corrigir-pre-commit-e-pre-push: lane land - #58

Merged
marlon-costa-dc merged 1 commit into
0.12.0-devfrom
feature/corrigir-pre-commit-e-pre-push
Aug 17, 2026
Merged

feature/corrigir-pre-commit-e-pre-push: lane land#58
marlon-costa-dc merged 1 commit into
0.12.0-devfrom
feature/corrigir-pre-commit-e-pre-push

Conversation

@marlon-costa-dc

@marlon-costa-dc marlon-costa-dc commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Automated land for bead mro-g3zl2 (feature/corrigir-pre-commit-e-pre-push).

Summary by CodeRabbit

  • Chores
    • Added automated checks to prevent draft or work-in-progress changes from being merged into integration branches.
    • Improved local validation behavior by safely skipping checks in unsupported workspaces and applicable WIP scenarios.
    • Increased the CI operation timeout to reduce failures during longer-running checks.

Summary by cubic

Blocks WIP/DRAFT merges into dev, develop, and 0.12.0-dev, scopes hooks for submodule workspaces, and raises CI=Y gate timeout from 60s to 120s to reduce flakiness.

  • Review notes

    • Adds merge-guard job that runs on PRs and blocks merges to protected branches when the PR is draft or the head branch matches ^wip/ or contains WIP.
    • Pre-commit hooks add a scope check: if .gitmodules exists, hooks run in self-scope only; pre-push hooks add a guard that skips gates on WIP/draft and fail-open when gh is unavailable or PR state is unresolvable.
    • Makefile: CI=Y bounded commands now use 120s; CI=N remains 300s.
  • Required actions

    • Before merging into dev, develop, or 0.12.0-dev, mark PRs “Ready for review” and remove wip/ or WIP from branch names.

Written for commit f2540c3. Summary will update on new commits.

Review in cubic

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 972d5638-e93f-4791-9d83-e6c0ea97b4e2

📥 Commits

Reviewing files that changed from the base of the PR and between b3b4978 and f2540c3.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .pre-commit-config.yaml
  • Makefile

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull-request workflow now blocks draft and WIP merges into protected branches. Local hooks skip unsupported or guarded contexts and clear repository-specific variables. The CI timeout increases from 60 to 120 seconds.

Changes

Merge and local execution guards

Layer / File(s) Summary
Protected branch merge guard
.github/workflows/ci.yml
Adds a pull-request job that allows non-protected targets and rejects drafts or WIP source branches for protected targets.
Guarded local hook execution
.pre-commit-config.yaml
Pre-commit and pre-push hooks skip .gitmodules workspaces and guarded pull-request states. Valid runs clear local Git and selector variables before invoking Make commands.
CI timeout adjustment
Makefile
Increases the CI VERB_BOUNDED timeout from 60 to 120 seconds. Non-CI timeout behavior is unchanged.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to f2540

The changes are merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the pre-commit and pre-push changes, which are real parts of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/corrigir-pre-commit-e-pre-push

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@marlon-costa-dc
marlon-costa-dc merged commit 3d1ef30 into 0.12.0-dev Aug 17, 2026
5 of 6 checks passed
@marlon-costa-dc
marlon-costa-dc deleted the feature/corrigir-pre-commit-e-pre-push branch August 18, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant