fix(types): preserve arbitrary tm.ok result payloads - #61
Merged
marlon-costa-dc merged 1 commit intoAug 24, 2026
Merged
Conversation
|
marlon-costa-dc
deleted the
fix/tm-ok-preserve-result-payload-flext-vaw
branch
August 24, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Keep the no-matcher tm.ok overload generic for any Result payload while retaining the TestResultValue bound for structural matchers.
Root cause
The closed TestResultValue bound caused Mypy to degrade valid downstream Result payloads to object, producing 159 var-annotated errors in flext-infra.
Changes
Evidence
Tracker: flext-vaw
Summary by cubic
Preserves arbitrary tm.ok result payload types to restore correct type inference and prevent downstream MyPy degradations. Old: tm.ok constrained payloads to TestResultValue, often collapsing them to object. New: tm.ok(result) is generic over TResult; tm.ok(result, **kwargs) remains bounded to support structural matchers. No runtime behavior change.
pydantic.BaseModelpayloads retain their type through tm.ok.Written for commit 203c081. Summary will update on new commits.