fix wildcard routes being skipped by fast path method lookup closes #693#694
Open
KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
Open
fix wildcard routes being skipped by fast path method lookup closes #693#694KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
Conversation
…lightphp#693 Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the route registration order regression introduced in v3.17.1 by the method-specific fast path added in #658.
closes #693
Fix
Store routes in
routesByMethodusing their global index in$routesas the array key. When building the fast path candidates, merge the two buckets andksortby key to restore registration order.Now the merged candidates are always in registration order regardless of method, and the fast path performance benefit (only URL-matching against eligible routes) is preserved.
Testing
Added regression test
testWildcardPassthroughRouteBeforeSpecificGetRouteinRouterTest.