ci: build the site on every PR - #10
Merged
Merged
Conversation
The only workflow here deployed on push to main, so a page that broke the export was found after it landed rather than on the PR. Runs the same `npx markline export` the deploy uses, so CI validates exactly what ships. Verified locally: `npm install && npx markline export` succeeds on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only workflow in this repo deploys on push to
main, so nothing checks a PR — a page that breaks the export was found after it landed.Runs the same
npx markline exportthe deploy workflow uses, so CI validates exactly what ships rather than a near-equivalent.MARKLINE_AI_KEYis unset in CI; the export skips AI suggestions gracefully without it.Verified locally on
main:npm install && npx markline exportsucceeds.Companion to the same change in the flo repo. Once this lands, #9 should be rebased so it actually gets checked before merging.