docs: the metric families are populated now - #11
Merged
Conversation
The caveat said flo_shard_* and the per-stream totals export as 0 because nothing recorded them on the write paths. That is no longer true — stream, queue, per-shard, workflow, processing, KV and tiered-log counters are all wired to their write paths now. The other half of the note still holds and stays: flo_cluster_nodes, flo_raft_leader_elections_total and flo_gossip_members are not implemented, so nobody should build a scrape config on them. Added the one remaining honest zero: flo_tiered_log_cold_hits_total is always 0 because the read path consults the hot ring and warm store only, never cold. Better stated than left for someone to interpret as a broken counter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to floruntime/flo#44, which asked for this note to be removed once the families were populated.
Half of it is now false and half still holds, so it is rewritten rather than deleted.
Removed — this is no longer true:
Stream, queue, per-shard, workflow, processing, KV and tiered-log counters are all wired to their write paths now (floruntime/flo#64, #67, #69).
Kept — still true, and worth keeping people off them:
Added — one honest zero that would otherwise read as a bug:
flo_tiered_log_cold_hits_totalis always0. The read path consults the hot ring and the warm store only, so a cold read is never counted there. Saying so beats leaving someone to wonder whether the counter is unwired.npx markline exportpasses.